isapir commented on PR #877: URL: https://github.com/apache/tomcat/pull/877#issuecomment-3189130840
Modern JVMs do a pretty good job at setting the memory values in the examples according to the specific system. I personally find the `-Xms` flag to not be useful in modern JVMs, and the upper limit of `-Xmx` to be too constricting for many systems at 2GB While I do think that a bit more information about `CATALINA_OPTS` can be useful, it can be added to the existing section 3.3 rather than adding a new section for it I am also concerned that the example snippets would discard other settings that already exist in CATALINA_OPTS as they set the values without taking into account the fact that a value might already exist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
