https://bz.apache.org/bugzilla/show_bug.cgi?id=69735
--- Comment #9 from Christopher Schultz <ch...@christopherschultz.net> --- Comments on the patch (latest is attachment #40058 at the time of this writing). I have only read the patch, not run it. 1. I believe content-negotiation in mod_negotiation is only performed if the original resource does not exist. I haven't done very careful checking on this. The current patch always performs it for all requests, even if the original request would have found exactly one file. The Filter only looked for other files if the original resource appeared to be missing. It would be good to understand user expectations in order to potentially improve performance. 2. One advantage of the Filter was that it could be bound only to certain URL patterns, while this DefaultServlet implementation has a single on/off switch. It would be nice to be able to enable/disable this behavior under some circumstances. For example, "only for index.html files" or "only in _this_ directory". We could implement some complicated system of configuration, or we could use Filters to enable content-negotiation by setting a request attribute before the DefaultServlet runs. We may want to package such a Filter along with Tomcat that can easily be used by end-users, but I think it would be trivial and the complexity comes from how the Filter is configured. 3. The DefaultServlet does not set the Vary header, which I think is important. 4. The unit test appears to be looking for index.html.fr, but the Accept-Language in the request prefers German. Also, the file index.html.fr doesn't appear to be a part of the patch, and I don't see any mock-objects that would suggest that the file is loaded from non-disk. Perhaps I don't understand how the test works. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
