On 28/05/2025 19:59, Christopher Schultz wrote:
Mark,
On 5/23/25 1:23 PM, Mark Thomas wrote:
The key differences of version 2.0.9 compared to 2.0.8 are:
- Update Windows build to use Visual Studio 2022
- The windows binaries in this release have been built with OpenSSL
3.5.0 and APR 1.7.6
The 2.0.x branch is primarily intended for use with Tomcat 10.1.x
onwards but can be used with earlier versions as long as the APR/
native connector is not used.
The proposed release artifacts can be found at [1],
and the build was done using tag [2].
The pdb files are a lot larger than previously. I'm not sure if this
is a bug or an expected consequence of the change in build process.
The Apache Tomcat Native 2.0.9 release is
[ ] Stable, go ahead and release
[ ] Broken because of ...
Not a vote, yet, but...
The Java code doesn't build. I think probably nobody actually cares.
I'd agree.
There are two problems:
1. The compiler versions are set to Java 11 but @Serial (added in
becf9d640858419f25f12558c964afb5a96ad369) doesn't exist until Java 14.
2. We are using StringBuilder.isEmpty (added in
becf9d640858419f25f12558c964afb5a96ad369) which doesn't exist until Java
15.
The build doesn't work in spite of the actual version of Java used for
the build due to the values of compile.release and/or
build.java.version. Setting them to "15" allows the Java build to succeed.
We need to up that to Java 21 since that is what 12.0.x builds with.
The README shows how to run the (Java) tests but there are no actual
tests to run. :/
I'll remove that part.
Thanks for the review.
Mark
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
