On Thu, Apr 3, 2025 at 9:10 PM Mark Thomas <ma...@apache.org> wrote: > > On 03/04/2025 19:34, Christopher Schultz wrote: > > Mark, > > > > On 4/3/25 1:38 PM, Mark Thomas wrote: > >> On 01/04/2025 19:56, Rémy Maucherat wrote: > >> > >>> The proposed 9.0.103 release is: > >>> [ ] -1, Broken - do not release > >>> [X] +1, Stable - go ahead and release as 9.0.103 > >> > >> +1 > >> > >> Build is cross-platform reproducible (Windows). > >> > >> Test pass on Linux, Windows and MacOS (M1). > >> > >> I did observe some test failures due to the known issue in the > >> AccessLogValve. > > > > Do you see any issues with the signed .exe installer? > > > > I simply downloaded the .exe from the dist server and checked it on > > Windows 11 and it didn't like the signature. > > Same here. It is reproducible but broken. > > We haven't been too concerned with missing signatures in the past. Less > sure about broken signatures. That might be more of a red flag for users. > > With this and the AccessLogValve issue I do wonder about re-rolling. > That said, I think users are better off with 9.0.103 than without it so > I am leaving my vote as +1.
I think I can picture a scenario consistent with what I did which would explain the bad signature (basically, I started with messing up due to using Java 24 and the javadoc bug, however the detached signature was created and had no reason to get deleted; it will probably have been picked up as detached sig when rebuilding instead of being replaced - all the other signatures and checksums will be redone however so they are correct and the build is reproducible -, and despite everything being the same Java 24 and Java 17 would differ), although I cannot be 100% sure. Since I think progress has been made on fixing other issues (log valve, build too complex, javadoc workaround), I'll tag 9.0.104 soonish after some further verification (and an improvement to rewrite). Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
