On 31/03/2025 19:52, Rémy Maucherat wrote:
On Mon, Mar 31, 2025 at 6:27 PM <ma...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 8a5e5475f1 Restore final keywords
8a5e5475f1 is described below
commit 8a5e5475f1ead35589dc8c5e359b9395838112b7
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Mar 31 17:27:02 2025 +0100
Restore final keywords
Removing final broke the signature tests for the pages TCK. final does
have a meaning for static methods - it prevents sub-classes re-defining
them.
I thought it was ok since it did not seem to generate TCK issues for
me (tried with your tomcat-tck repo).
Odd. It should have done. It was failures there that made me aware of
the issue. Maybe the TCK run picked up the wrong Tomcat version to test
against. By default it should be running against the latest CI
snapshots. You should be able to build a snapshot locally, publish it to
your local maven repo and use that.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
