This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 87fa09d914 Better use of StringBuilder
87fa09d914 is described below
commit 87fa09d9148ec6bfa6c03dcbcaf39ff15884d122
Author: remm <[email protected]>
AuthorDate: Thu Mar 27 09:53:28 2025 +0100
Better use of StringBuilder
Submitted by Dmitry Kryukov.
---
java/org/apache/tomcat/util/Diagnostics.java | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/java/org/apache/tomcat/util/Diagnostics.java
b/java/org/apache/tomcat/util/Diagnostics.java
index 779dd2aa01..3b832e99f9 100644
--- a/java/org/apache/tomcat/util/Diagnostics.java
+++ b/java/org/apache/tomcat/util/Diagnostics.java
@@ -273,7 +273,8 @@ public class Diagnostics {
* @return the formatted thread dump header
*/
private static String getThreadDumpHeader(ThreadInfo ti) {
- StringBuilder sb = new StringBuilder("\"" + ti.getThreadName() + "\"");
+ StringBuilder sb = new StringBuilder();
+ sb.append("\"").append(ti.getThreadName()).append("\"");
sb.append(" Id=").append(ti.getThreadId());
sb.append("
cpu=").append(threadMXBean.getThreadCpuTime(ti.getThreadId())).append(" ns");
sb.append("
usr=").append(threadMXBean.getThreadUserTime(ti.getThreadId())).append(" ns");
@@ -362,11 +363,7 @@ public class Diagnostics {
ThreadInfo[] tinfos =
threadMXBean.getThreadInfo(threadMXBean.findDeadlockedThreads(),
true, true);
if (tinfos != null) {
- StringBuilder sb =
- new
StringBuilder(sm.getString("diagnostics.deadlockFound"));
- sb.append(CRLF);
- sb.append(getThreadDump(tinfos));
- return sb.toString();
+ return sm.getString("diagnostics.deadlockFound") + CRLF +
getThreadDump(tinfos);
}
}
return "";
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
