On 21/03/2025 14:11, Christopher Schultz wrote:
All,
I'm looking at adding file-based allow/deny for the RemoteCIDR(Filter|
Valve) and I can see that there is a bunch of duplicate code between the
two classes.
Is there any reason not to re-use methods such as RemoteCIDR(Filter|
Valve).fillFromInput between the two classes?
They are in different packages, so maybe that's the reason?
Possibly. Moving the common code to o.a.catalina.util might be an
option. Or o.a.tomcat.util if the options for re-use extend beyond the
o.a.catalina package.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
