On 20/03/2025 11:24, Rémy Maucherat wrote:
On Thu, Mar 20, 2025 at 12:11 PM Mark Thomas <ma...@apache.org> wrote:
On 20/03/2025 10:09, r...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 3ae844ba28 Fix type related warnings
3ae844ba28 is described below
commit 3ae844ba28174672d00aed62e832d45a8cdf945b
Author: remm <r...@apache.org>
AuthorDate: Thu Mar 20 11:09:14 2025 +0100
Fix type related warnings
Are you sure all of these are needed? My IDE (Eclipse 2025.03) is
indicating that most of them are unnecessary.
I'm trying Idea (CE) and it was not happy about the (lack of) typing,
so warnings. I can revert most of it I guess, since it doesn't add
much either.
I wonder if that is because Idea is better at spotting the ambiguity or
if Eclipse is better at inferring the type.
I suspect the type inference is better as this is something I have
noticed gradually improve in Eclipse over time.
My main motivation is to have my IDE warning free so I can easily see
when the IDE spots that I have done something not quite right. Zero
warnings to > 0 warnings is easier to see than 4 warnings to 5 warnings.
I'd hope, with the right settings, we could be warning free on multiple
IDEs. Although that does go back to the issues with Javadoc and the
(slow) move to using Checkstyle for validation since it is IDE neutral.
Big +1 to the clean-ups you are doing though.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
