This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 660d5cfd6b996c980323267008c278f44af73d2c
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Mar 4 16:18:50 2025 +0000

    Update instructions
---
 BUILDING.txt | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/BUILDING.txt b/BUILDING.txt
index 74c1b94d83..6f767f4ab6 100644
--- a/BUILDING.txt
+++ b/BUILDING.txt
@@ -319,6 +319,7 @@ in build.xml and the default property values in 
build.properties.default.
         # Code signing of Windows installer
         do.codesigning=true
         codesigning.storepass=request-via-pmc
+        codesigning.keypass=request-via-pmc
 
     Release managers will be provided with the necessary credentials by the 
PMC.
 
@@ -326,15 +327,20 @@ in build.xml and the default property values in 
build.properties.default.
     you can use the detached signatures provided in the official releases.
     In this case you have to use the sources from the source release
     archive, which contains these signatures. You also have to build
-    on Windows, or use Wine, or use a special build of makensis to
-    create a reproducible installer, that fits the signature files.
+    on Windows, use Wine, or use a special build of makensis to create
+    a reproducible installer, that fits the signature files.
 
  5. Using a special "makensis" build on non-Windows (optional)
 
     If you want to build a reproducible installer on non-Windows
     by using "makensis" instead of "Wine", you need to build
-    "makensis" from a source download yourself using the following
-    recipe. To build makensis, you need python, scons and a C compiler.
+    "makensis" from a source download yourself. To build "makensis",
+    you need python, scons and a C compiler. You can build "makensis"
+    via an Ant target:
+
+    ant local-makensis
+
+    or you can build it manually using the following recipe.
 
     First detect the needed version by looking for nsis.version
     in build.properties.default.
@@ -350,10 +356,9 @@ in build.xml and the default property values in 
build.properties.default.
 
     Install the scons Python software construction tool.
 
-    Run the following command in the extracted NSIS source directory and set 
PATH:
+    Run the following command in the extracted NSIS source directory:
 
         scons UNICODE=yes PREFIX=${base.path}/nsis-${nsis.version}/Bin 
SKIPPLUGINS=all SKIPUTILS=all SKIPMISC=all NSIS_CONFIG_CONST_DATA_PATH=no 
VERSION=${nsis.version} install-compiler
-        export PATH=$PATH:${base.path}/nsis-${nsis.version}/Bin
 
     You need to specify the correct value in VERSION (this ends up in the 
installer binary
     so it needs to match). The PREFIX is not important, but you need to make 
sure
@@ -361,9 +366,6 @@ in build.xml and the default property values in 
build.properties.default.
     the NSIS binary distribution that "ant download-dist" installed. When using
     "NSIS_CONFIG_CONST_DATA_PATH=no" the binary is independent of the value of 
"PREFIX".
 
-    Use this "makensis" binary to make sure that it gets found after setting
-    the PATH environment variable.
-
     In addition set the ant property "nsis.tool" to "makensis" in
     build.properties.
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to