Hi remy,

I think the problem is real. Some portlet api and modularized web applications have this problem. Why you veto a fix without a better proposal? I don't see currently an option without a try/finally block.

regards
Peter



Am 19.06.2007 um 22:59 schrieb Remy Maucherat:

Peter Rossbach wrote:
Hi Remy and Filip
you veto my ApplicationDispatcher patch for Tomcat Release 5.5.25 (revision 545127) 7.6.2007 and see Bugreport 30949:
My patch fix following bugs:
After a exception at ApplicationDispatcher.forward and include is thrown:
- Memory Leak at STRICT_SERVLET_COMPILANCE is enabled
    Session counter never decrease
- Is crossContext=true at cluster is setup the crossContext session replication not working correct -The correct response close handling at forward is not called after an exception is thrown
=> wrequest.recycle is not called
Why unwrapRequest at forward is call twice?
    Inside processRequest
    and after wrap request at forward()
How we can elegant fix the bugs?

I didn't like your fix at all. Given the problem (if it's real) can basically be ignored, the fix would have to be really clean and not introduce any try/finally.

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to