This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push: new 3a6572b692 Re-apply standard formatting 3a6572b692 is described below commit 3a6572b692fb224ecdc7cb771c9ff3251d7f2644 Author: Mark Thomas <ma...@apache.org> AuthorDate: Fri Feb 7 14:32:07 2025 +0000 Re-apply standard formatting --- java/org/apache/catalina/WebResourceRoot.java | 2 +- java/org/apache/catalina/servlets/DataSourcePropertyStore.java | 9 ++++----- java/org/apache/catalina/servlets/DefaultServlet.java | 2 +- java/org/apache/catalina/servlets/WebdavServlet.java | 8 ++++---- java/org/apache/catalina/session/DataSourceStore.java | 3 ++- java/org/apache/catalina/util/RateLimiter.java | 2 +- java/org/apache/catalina/valves/JDBCAccessLogValve.java | 2 ++ java/org/apache/coyote/NonPipeliningProcessor.java | 4 ++-- java/org/apache/el/util/Validation.java | 2 +- 9 files changed, 18 insertions(+), 16 deletions(-) diff --git a/java/org/apache/catalina/WebResourceRoot.java b/java/org/apache/catalina/WebResourceRoot.java index f96dc7d7e8..b99874ee3f 100644 --- a/java/org/apache/catalina/WebResourceRoot.java +++ b/java/org/apache/catalina/WebResourceRoot.java @@ -425,7 +425,7 @@ public interface WebResourceRoot extends Lifecycle { /** * @return {@code true} if the main resources are read only, otherwise {@code false}. The default implementation - * returns {@code false}. + * returns {@code false}. */ default boolean isReadOnly() { return false; diff --git a/java/org/apache/catalina/servlets/DataSourcePropertyStore.java b/java/org/apache/catalina/servlets/DataSourcePropertyStore.java index bbb2cf3515..fd700dfc51 100644 --- a/java/org/apache/catalina/servlets/DataSourcePropertyStore.java +++ b/java/org/apache/catalina/servlets/DataSourcePropertyStore.java @@ -52,8 +52,7 @@ import org.w3c.dom.Node; * </ul> * The table name used can be configured using the <code>tableName</code> property of the store. * <p> - * Example table schema: - * <code>CREATE TABLE properties ( + * Example table schema: <code>CREATE TABLE properties ( * path VARCHAR(1024) NOT NULL, * namespace VARCHAR(64) NOT NULL, * name VARCHAR(64) NOT NULL, @@ -97,8 +96,7 @@ public class DataSourcePropertyStore implements WebdavServlet.PropertyStore { } /** - * @param dataSourceName the DataSource JNDI name, will be prefixed with - * java:comp/env for the lookup. + * @param dataSourceName the DataSource JNDI name, will be prefixed with java:comp/env for the lookup. */ public void setDataSourceName(String dataSourceName) { this.dataSourceName = dataSourceName; @@ -129,7 +127,8 @@ public class DataSourcePropertyStore implements WebdavServlet.PropertyStore { try { dataSource = (DataSource) ((new InitialContext()).lookup("java:comp/env/" + dataSourceName)); } catch (NamingException e) { - throw new IllegalArgumentException(sm.getString("webdavservlet.dataSourceStore.noDataSource", dataSourceName), e); + throw new IllegalArgumentException( + sm.getString("webdavservlet.dataSourceStore.noDataSource", dataSourceName), e); } } addPropertyStatement = "INSERT INTO " + tableName + " (path, namespace, name, node) VALUES (?, ?, ?, ?)"; diff --git a/java/org/apache/catalina/servlets/DefaultServlet.java b/java/org/apache/catalina/servlets/DefaultServlet.java index 80290468da..3ae7c4c032 100644 --- a/java/org/apache/catalina/servlets/DefaultServlet.java +++ b/java/org/apache/catalina/servlets/DefaultServlet.java @@ -1526,7 +1526,7 @@ public class DefaultServlet extends HttpServlet { if (response.isCommitted()) { /* * Ideally, checkIfRange() would be changed to return Boolean so the three states (satisfied, - * unsatisfied and error) could each be communicated via the return value. There isn't a backwards + * unsatisfied and error) could each be communicated via the return value. There isn't a backwards * compatible way to do that that doesn't involve changing the method name and there are benefits to * retaining the consistency of the existing method name pattern. Hence, this 'trick'. For the error * state, checkIfRange() will call response.sendError() which will commit the response which this method diff --git a/java/org/apache/catalina/servlets/WebdavServlet.java b/java/org/apache/catalina/servlets/WebdavServlet.java index 749665cbd6..de6cf2ef90 100644 --- a/java/org/apache/catalina/servlets/WebdavServlet.java +++ b/java/org/apache/catalina/servlets/WebdavServlet.java @@ -86,8 +86,8 @@ import org.xml.sax.SAXException; * users and WebDAV users, the WebDAV servlet may be mounted at a sub-path (e.g. <code>/webdav/*</code>) which creates * an additional mapping for the entire web application under that sub-path, with WebDAV access to all the resources. * <p> - * By default, the <code>WEB-INF</code> and <code>META-INF</code> directories are not accessible via WebDAV. This may - * be changed by setting the <code>allowSpecialPaths</code> initialisation parameter to <code>true</code>. + * By default, the <code>WEB-INF</code> and <code>META-INF</code> directories are not accessible via WebDAV. This may be + * changed by setting the <code>allowSpecialPaths</code> initialisation parameter to <code>true</code>. * <p> * It is also possible to enable WebDAV access to a sub-set of the standard web application URL space rather than * creating an additional, WebDAV specific mapping. To do this, map the WebDAV servlet to the desired sub-path and set @@ -1860,8 +1860,8 @@ public class WebdavServlet extends DefaultServlet implements PeriodicEventListen private boolean isSpecialPath(final String path) { if (!allowSpecialPaths) { String upperCasePath = path.toUpperCase(Locale.ENGLISH); - if (upperCasePath.startsWith("/WEB-INF/") || upperCasePath.startsWith("/META-INF/") - || upperCasePath.equals("/WEB-INF") || upperCasePath.equals("/META-INF")) { + if (upperCasePath.startsWith("/WEB-INF/") || upperCasePath.startsWith("/META-INF/") || + upperCasePath.equals("/WEB-INF") || upperCasePath.equals("/META-INF")) { return true; } } diff --git a/java/org/apache/catalina/session/DataSourceStore.java b/java/org/apache/catalina/session/DataSourceStore.java index ff56fd2137..3933463cce 100644 --- a/java/org/apache/catalina/session/DataSourceStore.java +++ b/java/org/apache/catalina/session/DataSourceStore.java @@ -649,7 +649,8 @@ public class DataSourceStore extends StoreBase { Context envCtx = (Context) (new InitialContext()).lookup("java:comp/env"); this.dataSource = (DataSource) envCtx.lookup(this.dataSourceName); } catch (NamingException e) { - context.getLogger().error(sm.getString("dataSourceStore.wrongDataSource", this.dataSourceName), e); + context.getLogger().error(sm.getString("dataSourceStore.wrongDataSource", this.dataSourceName), + e); } } } diff --git a/java/org/apache/catalina/util/RateLimiter.java b/java/org/apache/catalina/util/RateLimiter.java index d1beb65399..bdd8b27736 100644 --- a/java/org/apache/catalina/util/RateLimiter.java +++ b/java/org/apache/catalina/util/RateLimiter.java @@ -92,7 +92,7 @@ public interface RateLimiter { /** * Provide the quota header for this rate limit for a given request count within the current time window. * - * @param requestCount The request count within the current time window + * @param requestCount The request count within the current time window * * @return the quota header for the given value of request count * diff --git a/java/org/apache/catalina/valves/JDBCAccessLogValve.java b/java/org/apache/catalina/valves/JDBCAccessLogValve.java index c598759874..c4fef50108 100644 --- a/java/org/apache/catalina/valves/JDBCAccessLogValve.java +++ b/java/org/apache/catalina/valves/JDBCAccessLogValve.java @@ -98,6 +98,7 @@ import org.apache.tomcat.util.ExceptionUtils; * * @author Andre de Jesus * @author Peter Rossbach + * * @deprecated Non scalable design, and not documented. Will be removed in Tomcat 12. */ @Deprecated @@ -577,6 +578,7 @@ public class JDBCAccessLogValve extends ValveBase implements AccessLog { /** * Prepare tables for processing. Used by subclasses for testing. + * * @throws SQLException if an exception occurs */ protected void prepare() throws SQLException { diff --git a/java/org/apache/coyote/NonPipeliningProcessor.java b/java/org/apache/coyote/NonPipeliningProcessor.java index 75a6da0830..a6e8759a57 100644 --- a/java/org/apache/coyote/NonPipeliningProcessor.java +++ b/java/org/apache/coyote/NonPipeliningProcessor.java @@ -18,8 +18,8 @@ package org.apache.coyote; /** * Marker interface used to indicate that the {@link Processor} does not implement pipe-lining of requests (e.g. - * HTTP/1.1 supports pipe-lining whereas HTTP/2 does not) which may enable some components to clear references sooner - * to aid GC. + * HTTP/1.1 supports pipe-lining whereas HTTP/2 does not) which may enable some components to clear references sooner to + * aid GC. */ public interface NonPipeliningProcessor extends Processor { diff --git a/java/org/apache/el/util/Validation.java b/java/org/apache/el/util/Validation.java index a1e4911189..9802dea9dc 100644 --- a/java/org/apache/el/util/Validation.java +++ b/java/org/apache/el/util/Validation.java @@ -30,7 +30,7 @@ public class Validation { "false", "final", "finally", "float", "for", "goto", "if", "implements", "import", "instanceof", "int", "interface", "long", "native", "new", "null", "package", "private", "protected", "public", "return", "short", "static", "strictfp", "super", "switch", "synchronized", "this", "throw", "throws", "transient", - "true", "try", "void", "volatile", "while"}; + "true", "try", "void", "volatile", "while" }; private static final boolean IS_SECURITY_ENABLED = (System.getSecurityManager() != null); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org