On Thu, Dec 12, 2024 at 9:35 AM Mark Thomas <ma...@apache.org> wrote: > > Hi all, > > Two test classes have been added for RFC 9110 section 13: > > TestDefaultServletRfc9110Section13 > TestDefaultServletRfc9110Section13Parameterized > > The parameterized version is a subset of the non-parameterized. I have > confirmed via code coverage that the parameterized version is currently > adding no value. > > What is the plan here? I'd like to expand these tests to improve > coverage. I also see possibilities to improve the current implementation > and would like to add tests to cover those cases. > > Will the parameterized tests be deleted? Or is the plan for them to be > expanded to provide the same level of coverage as the non-parameterized > tests and then delete the non-parameterized versions? > > The parameterized approach looks to be the better long term option as it > provides for less overall code and doesn't group multiple tests into a > single test execution. > > I'm happy to work on improving the parameterized tests with a view to > removing the non-parameterized version but I don't want to spend too > much time on that if there is a different overall plan.
+1 for your plan. Rémy > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
