This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit d98bf19c21619dd52a98c2b21aa6434e03e1b118
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Dec 3 12:07:26 2024 +0000
Align with Commons DBCP
---
java/org/apache/tomcat/dbcp/dbcp2/BasicDataSource.java | 6 ------
java/org/apache/tomcat/dbcp/dbcp2/DataSourceMXBean.java | 2 --
java/org/apache/tomcat/dbcp/dbcp2/DelegatingStatement.java | 1 -
java/org/apache/tomcat/dbcp/dbcp2/PoolingConnection.java | 1 -
4 files changed, 10 deletions(-)
diff --git a/java/org/apache/tomcat/dbcp/dbcp2/BasicDataSource.java
b/java/org/apache/tomcat/dbcp/dbcp2/BasicDataSource.java
index 043369b22b..9509bc1414 100644
--- a/java/org/apache/tomcat/dbcp/dbcp2/BasicDataSource.java
+++ b/java/org/apache/tomcat/dbcp/dbcp2/BasicDataSource.java
@@ -438,7 +438,6 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
* </p>
*
* @return A new connection factory.
- *
* @throws SQLException If the connection factory cannot be created
*/
protected ConnectionFactory createConnectionFactory() throws SQLException {
@@ -544,7 +543,6 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
* implementation class.
*
* @throws SQLException if unable to create a datasource instance
- *
* @return A new DataSource instance
*/
protected DataSource createDataSourceInstance() throws SQLException {
@@ -579,7 +577,6 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
*
* @param driverConnectionFactory JDBC connection factory
* @throws SQLException if an error occurs creating the
PoolableConnectionFactory
- *
* @return A new PoolableConnectionFactory configured with the current
configuration of this BasicDataSource
*/
protected PoolableConnectionFactory createPoolableConnectionFactory(final
ConnectionFactory driverConnectionFactory)
@@ -688,7 +685,6 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
*
* @param user Database user on whose behalf the Connection is being made
* @param pass The database user's password
- *
* @throws UnsupportedOperationException always thrown.
* @throws SQLException if a database access error occurs
* @return nothing - always throws UnsupportedOperationException
@@ -1374,7 +1370,6 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
* Gets the {code testOnBorrow} property.
*
* @return true if objects are validated before being borrowed from the
pool
- *
* @see #setTestOnBorrow(boolean)
*/
@Override
@@ -1486,7 +1481,6 @@ public class BasicDataSource implements DataSource,
BasicDataSourceMXBean, MBean
* and reclaim pool capacity.
*
* @param connection The Connection to invalidate.
- *
* @throws IllegalStateException if invalidating the connection failed.
* @since 2.1
*/
diff --git a/java/org/apache/tomcat/dbcp/dbcp2/DataSourceMXBean.java
b/java/org/apache/tomcat/dbcp/dbcp2/DataSourceMXBean.java
index 2f40c52b81..b70b6dacc4 100644
--- a/java/org/apache/tomcat/dbcp/dbcp2/DataSourceMXBean.java
+++ b/java/org/apache/tomcat/dbcp/dbcp2/DataSourceMXBean.java
@@ -356,7 +356,6 @@ public interface DataSourceMXBean {
* See {@link BasicDataSource#restart()}
*
* @throws SQLException if an error occurs initializing the data source.
- *
* @since 2.8.0
*/
default void restart() throws SQLException {
@@ -367,7 +366,6 @@ public interface DataSourceMXBean {
* See {@link BasicDataSource#start()}
*
* @throws SQLException if an error occurs initializing the data source.
- *
* @since 2.8.0
*/
default void start() throws SQLException {
diff --git a/java/org/apache/tomcat/dbcp/dbcp2/DelegatingStatement.java
b/java/org/apache/tomcat/dbcp/dbcp2/DelegatingStatement.java
index faf06e18be..2f31b1adae 100644
--- a/java/org/apache/tomcat/dbcp/dbcp2/DelegatingStatement.java
+++ b/java/org/apache/tomcat/dbcp/dbcp2/DelegatingStatement.java
@@ -450,7 +450,6 @@ public class DelegatingStatement extends AbandonedTrace
implements Statement {
* </p>
*
* @return The innermost delegate, may return null.
- *
* @see #getDelegate
*/
public Statement getInnermostDelegate() {
diff --git a/java/org/apache/tomcat/dbcp/dbcp2/PoolingConnection.java
b/java/org/apache/tomcat/dbcp/dbcp2/PoolingConnection.java
index 76d013033c..2422c70465 100644
--- a/java/org/apache/tomcat/dbcp/dbcp2/PoolingConnection.java
+++ b/java/org/apache/tomcat/dbcp/dbcp2/PoolingConnection.java
@@ -373,7 +373,6 @@ public class PoolingConnection extends
DelegatingConnection<Connection>
* Normalizes the given SQL statement, producing a canonical form that is
semantically equivalent to the original.
*
* @param sql The statement to be normalized.
- *
* @return The canonical form of the supplied SQL statement.
*/
protected String normalizeSQL(final String sql) {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
