On 28/11/2024 11:47, Rémy Maucherat wrote:
On Thu, Nov 28, 2024 at 11:06 AM Mark Thomas <ma...@apache.org> wrote:
On 28/11/2024 09:22, Rémy Maucherat wrote:
On Thu, Nov 28, 2024 at 10:11 AM <ma...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 5970fa4b6c Avoid conflicts over derby.log when tests are run in
parallel
5970fa4b6c is described below
Thanks for finding the proper way to do it.
I appreciate the thanks but it felt a bit of a hack. I'd rather have set
the system property just in the tests that used Derby but that would
have required more invasive changes to expose the temporary directory
via a static rather than instance method.
Maybe I should do that refactoring. We don't need to worry about
backwards compatibility for the API for the tests.
It looked good enough to me.
Ok.
Since Derby is now nice for testing, I was thinking about more tests
(and possibly more DB features included since things are better
tested). For example the DataSourceStore, and so on.
Sounds good.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
