Hi there,
I checked build reproducibility for the first time (apologies) and it
worked pretty well, at least for TC 11 and 10.1. That is great.
I have a few observations to share:
1) codesigning, gpg
:::::::::::::::::::
The source code includes the build.properties.release file. Two of its
lines are IMHO questionable:
do.codesigning=true
gpg.exec=C:/Program Files (x86)/GnuPG/bin/gpg.exe
These lines mean, that if I just want to check reproducibility, I need
to set do.codesigning=false in my local build.properties. In
BUILDING.txt we document, that you have to set do.codesigning=true to
use codesigning, but in fact it is already set to true and you have to
set to false to not use code signing.
Similar for gpg.exec: Since I can not use the RM's key, when doing a
reproducibility check, I would not sign the files using gpg. That should
be the default and for TC 11 and 10.1 it was for me, because the value
of gpg.exec in the build.properties.release did not point to a valid
path on my system. For TC 9 it did, so I had to overwrite gpg.exec.
Maybe it would be better to add the two lines commented out? At least
for the gpg.exec it would still document, what was used without making
it the default value on other user's systems?
2) Reproducibility for TC 9
:::::::::::::::::::::::::::
If I run "ant release" with Java 17 as suggested in
build.properties.release, I get the error, that for release including
ffm you need 22. But if I run it with Java 22 then it seems I do not get
a reproducible build?
3) locale
:::::::::
To make the build documentation reproducible I had to set
export LANG=en_US.utf8
I did not check, whether and how I can replace setting a JVM system
property instead. But I think if we want to make the build reproducible
including docs, we need to either document the locale settings in
build.properties.release or even better standardize on a given one. I
think standardizing on en_US.utf8 should be fine.
Thanks and best regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
