(tomcat) branch 10.1.x updated: Fix BZ 69429 - optimize getParameters() for zero parameters

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
     new bed3b86708 Fix BZ 69429 - optimize getParameters() for zero parameters
bed3b86708 is described below

commit bed3b86708dba2a27b9b1bc5a8471e56f2e196a8
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Nov 4 16:09:22 2024 +0000

    Fix BZ 69429 - optimize getParameters() for zero parameters
---
 java/org/apache/el/parser/AstMethodParameters.java | 11 +++++++++--
 webapps/docs/changelog.xml                         |  5 +++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/el/parser/AstMethodParameters.java 
b/java/org/apache/el/parser/AstMethodParameters.java
index 8556fe7f9f..4f5c78c5c9 100644
--- a/java/org/apache/el/parser/AstMethodParameters.java
+++ b/java/org/apache/el/parser/AstMethodParameters.java
@@ -24,17 +24,24 @@ import org.apache.el.lang.EvaluationContext;
 
 public final class AstMethodParameters extends SimpleNode {
 
+    private static final Object[] EMPTY_OBJECT_ARRAY = new Object[0];
+
     public AstMethodParameters(int id) {
         super(id);
     }
 
 
     public Object[] getParameters(EvaluationContext ctx) {
+        int numChildren = this.jjtGetNumChildren();
+        // Optimise simple case
+        if (numChildren == 0) {
+            return EMPTY_OBJECT_ARRAY;
+        }
         List<Object> params = new ArrayList<>();
-        for (int i = 0; i < this.jjtGetNumChildren(); i++) {
+        for (int i = 0; i < numChildren; i++) {
             params.add(this.jjtGetChild(i).getValue(ctx));
         }
-        return params.toArray(new Object[0]);
+        return params.toArray(EMPTY_OBJECT_ARRAY);
     }
 
 
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 2c892aa59f..590dd918d0 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -297,6 +297,11 @@
         <code>Enum</code> is encountered. Instead, resolve the value at 
runtime.
         Patch provided by John Engebretson. (markt)
       </fix>
+      <fix>
+        <bug>69429</bug>: Optimise EL evaluation of method parameters for
+        methods that do not accept any parameters. Patch provided by John
+        Engebretson. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Other">


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org