https://bz.apache.org/bugzilla/show_bug.cgi?id=69355
--- Comment #5 from Remy Maucherat <r...@apache.org> --- (In reply to Chen Jp from comment #4) > (In reply to Remy Maucherat from comment #3) > > I see a trend in the PRs that you are submitting. Trying to be as precise as > > possible is a commendable goal, but the problem is that this exactitude does > > not make much sense in the context of Tomcat since the randomness of network > > transport is always present. As a result, it can be better to be as > > efficient as possible and accept deviating a few % off target. > > > > Q: Are you using a tool to identify these issues ? Finding them by yourself > > on your own would be very impressive. > > If extra accuracy doesn't cost much, why not? It's useful for debugging > purpose. > > A new spec draft is published recently, on Oct 7. Please see > https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers/ > > A: As a senior Javaer but not so familiar with tomcat source code(especially > on tomcat-http11/http2-communication part), hope to contribute. First of > all, I do think that using of code quality tool (+ AI.) is a basic skill for > us. There is no reason not to fix the issues/bugs, no matter how they are > identified (100% manually or 95% artificially). Secondary, if you have > similar tool which can identify this BZ rate-limit-enhancement feather > request, I'm very interesting in it, please share it with me. > > per comment, replacement PR present. > (https://github.com/apache/tomcat/pull/760) Sure ok, 100% precision is better, so I am not against fixing it if there's no downside. However, there's a lot of analysis needed to find this one, and the benefit for the fix is minimal to non existent. So overall I am surprised you did not find any other higher impact issue. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
