https://bz.apache.org/bugzilla/show_bug.cgi?id=69382
Anurag Dubey <anura...@amazon.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #2 from Anurag Dubey <anura...@amazon.com> --- The concern is valid, see how these repeated-evaluations can possibly be commonized for the shared code snippet - ``` String proprietaryEvaluatedFeatureTemplate = (String) PageContextImpl.proprietaryEvaluate("${feature.template}", String.class, (PageContext) _jspx_page_context, null); char seperator = (proprietaryEvaluatedFeatureTemplate).indexOf('?') > 0 ? '&' : '?'; String characterEncoding = request.getCharacterEncoding(); String proprietaryEvaluatedFeatureName = (String) PageContextImpl.proprietaryEvaluate("${feature.featureName}", String.class, (PageContext) _jspx_page_context, null); String featureName = proprietaryEvaluatedFeatureTemplate + seperator + JspRuntimeLibrary.URLEncode("featureName", characterEncoding) + "=" + JspRuntimeLibrary.URLEncode(proprietaryEvaluatedFeatureName, characterEncoding); org.apache.jasper.runtime.JspRuntimeLibrary.include(request, response, featureName, out, false); ``` -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org