On 2024/10/06 18:43:27 Mark Thomas wrote:
> On 06/10/2024 19:04, Michael Osipov wrote:
> > On 2024/10/06 14:18:34 Mark Thomas wrote:
> >> On 05/10/2024 18:23, micha...@apache.org wrote:
> >>> This is an automated email from the ASF dual-hosted git repository.
> >>>
> >>> michaelo pushed a commit to branch 11.0.x
> >>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >>>
> >>>
> >>> The following commit(s) were added to refs/heads/11.0.x by this push:
> >>>        new 4108bf15b5 Improve HTML output of <code>DefaultServlet
> >>> 4108bf15b5 is described below
> >>>
> >>> commit 4108bf15b54cc82b56736edf07cff4561e8d457c
> >>> Author: Michael Osipov <micha...@apache.org>
> >>> AuthorDate: Sat Oct 5 19:18:17 2024 +0200
> >>>
> >>>       Improve HTML output of <code>DefaultServlet
> >>
> >> How does this improve the output? It appears to just be adding
> >> (unnecessary) new lines in the HTML source.
> > 
> > I agree with you so far that my wording is bad on the summary. It does not 
> > change the HTML code, but simply makes line breaks consistent. No 
> > functional change.
> 
> OK. Not something that is high on my list of priotities but since we are 
> here...
> 
> Should the priority be to make the source clear / readable or should we 
> be aiming to minimise it (remove line breaks, comments etc) for 
> (marginally) better response time. I can see arguments for both.

Both objectives are valid.

> While bandwidth is certainly more plentiful than it was 20 years ago, it 
> still pains me to see any of it wasted. Although looking at a typical 
> website I might be the only one that feels that way.
> 
> If the source is readable then it makes it easier for us to work with if 
> we ever want to change anything. It is also easier for contributors to 
> patch.
> 
> Given the small scale of the potential reduction, the maintenance 
> benefits and the (relatively) small resources concerned I think I am 
> leaning towards readable but what does everyone else think?

Personally, I prefer readability over compactness because it makes maintenance 
and contributions easier. I don't mind a flag for this, but those few bytes 
saved are negligiable. One still can use GZIP compression if the client 
requests it or even a filter to compact the source. I really often use Ctrl+U 
to look at source code and often I need to format it to make it reviewable :-(

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to