On Fri, Oct 4, 2024 at 3:16 AM Rainer Jung <rainer.j...@kippdata.de> wrote:
>
> Am 04.10.24 um 01:12 schrieb Rainer Jung:
> > Am 03.10.24 um 19:58 schrieb Mark Thomas:
> >> The proposed Apache Tomcat 11.0.0 release is now available for voting.
> >>
> >> The notable changes compared to 11.0.0-M26 include:
> >>
> >> - Multiple fixes and improvements for WebDAV
> >> - Improvements to the recently adding request/response recycling for
> >> HTTP/2
> >> - Improve the stability of Tomcat Native during GC
> >>
> >> For full details, see the change log:
> >> https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html
> >>
> >> Applications that run on Tomcat 9 and earlier will not run on Tomcat
> >> 11 without changes. Java EE applications designed for Tomcat 9 and
> >> earlier may be placed in the $CATALINA_BASE/webapps-javaee directory
> >> and Tomcat will automatically convert them to Jakarta EE and copy them
> >> to the webapps directory. Applications using deprecated APIs may
> >> require further changes.
> >>
> >> It can be obtained from:
> >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0/
> >>
> >> The Maven staging repo is:
> >> https://repository.apache.org/content/repositories/orgapachetomcat-1517
> >>
> >> The tag is:
> >> https://github.com/apache/tomcat/tree/11.0.0
> >> 56e547d387ab49f688c93fe9ca082b1b5d94deed
> >>
> >> The proposed 11.0.0 release is:
> >> [ ] -1 Broken - do not release
> >> [ ] +1 Stable - go ahead and release as 11.0.0
> >
> > I am seeing unit test failures for
> > org.apache.catalina.manager.TestHostManagerWebapp:
> >
> > Testcase: testServlet took 5.454 sec
> > FAILED
> > expected:<200> but was:<404>
> > junit.framework.AssertionFailedError: expected:<200> but was:<404>
> > at
> > org.apache.catalina.manager.TestHostManagerWebapp.testServlet(TestHostManagerWebapp.java:138)
> > at java.base/
> > jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at java.base/
> > jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> > at java.base/
> > jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >
> >
> > My test just started, so I only know about TC 11 with Java 17 and TC
> > 10.1 with Java 11. Both combinations show the same problem. Until know
> > the tests only ran for NIO. I have not seen such a failure for older
> > versions.
>
> The test is new, which explains, that I did not see such behavior before.
>
> Yes, my path setup might be a bit strange, but until now tests never
> failed because of that. It seems to me the host-manager test fails, when
> it calls a URL in the manager, but the test class did not deploy the
> manager. Depending on the setup it might be there nevertheless?
>
> The log gives the following additional error:
>
> 04-Oct-2024 01:07:23.204 INFO [http-nio-127.0.0.1-auto-1-exec-4]
> org.apache.catalina.core.ApplicationContext.log HostManager: add: Adding
> host [newhost]
> 04-Oct-2024 01:07:23.312 INFO [http-nio-127.0.0.1-auto-1-exec-4]
> org.apache.catalina.startup.HostConfig.deployDescriptor Deploying
> deployment descriptor
> [/esb-vmhost/vmshared/autobuild/workdirs/20241004_004239/bld/tomcat101_test.rhel6.x86_64/output/test-tmp/test7121413698282320105/conf/Tomcat/newhost/manager.xml]
> 04-Oct-2024 01:07:23.382 SEVERE [http-nio-127.0.0.1-auto-1-exec-4]
> org.apache.catalina.startup.HostConfig.deployDescriptor Error deploying
> deployment descriptor
> [/esb-vmhost/vmshared/autobuild/workdirs/20241004_004239/bld/tomcat101_test.rhel6.x86_64/output/test-tmp/test7121413698282320105/conf/Tomcat/newhost/manager.xml]
> java.lang.IllegalStateException: Error starting child
> at
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:602)
> at
> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:571)
> at
> org.apache.catalina.core.StandardHost.addChild(StandardHost.java:654)
> at
> org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:635)
> at
> org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1889)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at
> java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
> at
> java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:118)
> at
> org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.java:530)
> at
> org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:421)
> at
> org.apache.catalina.startup.HostConfig.start(HostConfig.java:1629)
> at
> org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:303)
> at
> org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:109)
> at
> org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:385)
> at
> org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:332)
> at
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:776)
> at
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:772)
> at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
> at
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:599)
> at
> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:571)
> at
> org.apache.catalina.core.StandardEngine.addChild(StandardEngine.java:166)
> at
> org.apache.catalina.manager.host.HostManagerServlet.add(HostManagerServlet.java:385)
> at
> org.apache.catalina.manager.host.HostManagerServlet.add(HostManagerServlet.java:226)
> at
> org.apache.catalina.manager.host.HostManagerServlet.doGet(HostManagerServlet.java:186)
> at
> jakarta.servlet.http.HttpServlet.service(HttpServlet.java:564)
> at
> jakarta.servlet.http.HttpServlet.service(HttpServlet.java:658)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:195)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140)
> at
> org.apache.catalina.filters.HttpHeaderSecurityFilter.doFilter(HttpHeaderSecurityFilter.java:129)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:164)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:167)
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:598)
> at
> org.apache.catalina.valves.RequestFilterValve.process(RequestFilterValve.java:355)
> at
> org.apache.catalina.valves.RemoteAddrValve.invoke(RemoteAddrValve.java:54)
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:115)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
> at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:663)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:344)
> at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:384)
> at
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
> at
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:905)
> at
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1741)
> at
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
> at
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1190)
> at
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
> at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
> at java.base/java.lang.Thread.run(Thread.java:829)
> Caused by: org.apache.catalina.LifecycleException: Failed to start
> component [org.apache.catalina.webresources.StandardRoot@61579e15]
> at
> org.apache.catalina.util.LifecycleBase.handleSubClassException(LifecycleBase.java:402)
> at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:179)
> at
> org.apache.catalina.core.StandardContext.resourcesStart(StandardContext.java:4108)
> at
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4230)
> at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
> at
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:599)
> ... 50 more
> Caused by: java.lang.IllegalArgumentException: The main resource set
> specified
> [/esb-vmhost/vmshared/autobuild/workdirs/20241004_004239/bld/tomcat101_test.rhel6.x86_64/webapps/manager]
> is not a directory or war file, or is not readable (it does not exist or
> permissions to access it are missing)
> at
> org.apache.catalina.webresources.StandardRoot.createMainResourceSet(StandardRoot.java:749)
> at
> org.apache.catalina.webresources.StandardRoot.startInternal(StandardRoot.java:707)
> at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
> ... 54 more
> 04-Oct-2024 01:07:23.398 INFO [http-nio-127.0.0.1-auto-1-exec-4]
> org.apache.catalina.startup.HostConfig.deployDescriptor Deployment of
> deployment descriptor
> [/esb-vmhost/vmshared/autobuild/workdirs/20241004_004239/bld/tomcat101_test.rhel6.x86_64/output/test-tmp/test7121413698282320105/conf/Tomcat/newhost/manager.xml]
> has finished in [85] ms
>
> If no one beats me to it, I will try with additional manager deployment
> in the test class tomorrow after sleeping a bit.
>
> Surely this doesn't look like a showstopper.
It is testing a very very old feature (which was untested, and I guess
unused). It is trying to deploy the manager for the newly created host
using the default manager webapp.
The docBase is defined as: docBase="${catalina.home}/webapps/manager"
The location is unreliable for the testsuite at least, so I'll improve
the test. For me it ends up as the Tomcat source dir, where it works
(webapps/manager is there basically since it's the Tomcat sources).
Rémy
> Best regards,
>
> Rainer
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
