https://bz.apache.org/bugzilla/show_bug.cgi?id=69362

--- Comment #13 from Michael Osipov <micha...@apache.org> ---
(In reply to Michael Osipov from comment #12)
> (In reply to Christopher Schultz from comment #11)
> > (In reply to Mark Thomas from comment #6)
> > > Final paragraph of 9.6.1.
> > 
> > Also, the complete example in 9.6.2 includes this specific case, and only
> > includes the file and not its parent directory in the response.
> 
> This means that our current implementation is not correct for the
> Request-URI collection:
> > Map<String,Integer> errorList = new LinkedHashMap<>();
> > 
> > deleteCollection(req, path, errorList);
> > if (!resource.delete()) {
> >     errorList.put(path, 
> > Integer.valueOf(WebdavStatus.SC_METHOD_NOT_ALLOWED));
> > }
> > 
> > if (!errorList.isEmpty()) {
> >     sendReport(req, resp, errorList);
> >     return false;
> > }
> 
> Based you your comment we need to do:
> > -            if (!resource.delete()) {
> > -                errorList.put(path, 
> > Integer.valueOf(WebdavStatus.SC_METHOD_NOT_ALLOWED));
> > -            }
> > +            resource.delete();

this patch is incorrect because if we consider that the collection is empty,
but deleting the collection fails the client would never see an error. This is
a separate issue which should be reported and handled separately. Here, I will
stick to the comment update only.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to