On 06/09/2024 12:24, Rémy Maucherat wrote:
On Fri, Sep 6, 2024 at 1:19 PM Mark Thomas <ma...@apache.org> wrote:

On 06/09/2024 12:14, ma...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
       new c5334fb785 Add lifecycle event detail for Server
c5334fb785 is described below

commit c5334fb78580f324f58dab4848bea27934a09c86
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Sep 6 12:12:16 2024 +0100

      Add lifecycle event detail for Server

Question.

Do I add this for all the components that implement lifecycle (for
completeness) or do I add a note listing the other components on the
diagram that also use initInternal() and fire lifecycle events for
simplicity / clarity?

I'm currently leaning towards completeness rather than simplicity/clarity.

Thoughts?

The start one seems to have everything but as a result it is more
cluttered. I suppose it is best to have a complete view.

That is what I was thinking. It also makes it more obvious that the Adapter and the Protocol don't have lifecycle events.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to