вт, 3 сент. 2024 г. в 19:40, Mark Thomas <ma...@apache.org>:

> > commit ab21ffadbdc2b8d8cb8db23758aa74ba786cdf4c
> > Author: Mark Thomas <ma...@apache.org>
> > AuthorDate: Tue Sep 3 17:08:09 2024 +0100
> >
> >      Add instructions to edit via POPEditor.com to all translated files
>
> I haven't run an import with this commit in place yet. I wanted to give
> folks a chance to review the text before it was added to every
> translated file.

> > +    static void insertEditInstructions(Writer w) throws IOException {
> > +        w.write(System.lineSeparator());
> > +        w.write("# Do not edit this file directly. Translations are 
> > managed via poeditor.");
> > +        w.write(System.lineSeparator());
> > +        w.write("# Join to edit translations: 
> > https://poeditor.com/join/project/NUTIjDWzrl";);
> > +        w.write(System.lineSeparator());
> > +        w.write("# View the translations    : 
> > https://poeditor.com/projects/view?id=221603";);
> > +        w.write(System.lineSeparator());

I think it'd be better to refer to our own page instead of a direct
link to a 3rd party site.

a, Source code lives for years,and links may become outdated.
b. A link without accompanying instructions may be not helpful.

Maybe refer to the existing "Get Involved" page (improve it?) instead
of the Wiki one.
https://tomcat.apache.org/getinvolved.html

BTW, permalink to the Wiki page is
https://cwiki.apache.org/confluence/x/vIPzBQ

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to