On Mon, Aug 5, 2024 at 11:22 PM Christopher Schultz
<ch...@christopherschultz.net> wrote:
>
> Rémy,
>
> On 8/2/24 19:02, Rémy Maucherat wrote:
> > The proposed Apache Tomcat 9.0.93 release is now available for voting.
> >
> > The notable changes compared to 9.0.91 are:
> >
> > - Align HTTP/2 with HTTP/1.1 and recycle the container internal request
> >     and response processing objects by default. This behaviour can be
> >     controlled via the new discardRequestsAndResponses attribute on the
> >     HTTP/2 upgrade protocol.
> >
> > - Add OpenSSL support for FFM. Using this feature requires Java 22
> >     or newer.
> >
> > - Add support for RFC 8297 (Early Hints). Applications can use this
> >     feature by casting the HttpServletResponse to
> >     org.apache.catalina.connector.Reponse and then calling the method
> >     void sendEarlyHints()
> >
> > For full details, see the changelog:
> > https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.93/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1510
> >
> > The tag is:
> > https://github.com/apache/tomcat/tree/9.0.93
> > a33d708d9b078e0d7bc8abda91c8634c4f338d99
> >
> > The proposed 9.0.93 release is:
> > [ ] -1, Broken - do not release
> > [ ] +1, Stable - go ahead and release as 9.0.93
>
> +1 for stable release.
>
> Build is reproducible and the unit tests pass on MacOS x86-64.
>
> I still see a weird difference in the -fulldocs package that do not make
> any sense to me:
>
> In the file list:
> │ │ --rw-r--r--   0        0        0  9426093 2024-08-02
> 21:24:59.000000 tomcat-9.0-doc/api/index-all.html
> │ │ +-rw-r--r--   0        0        0  9426102 2024-08-02
> 21:24:59.000000 tomcat-9.0-doc/api/index-all.html
>
> In the file index-all.html:
> │ │ -<dt><a
> href="org/apache/tomcat/util/compat/Jre22Compat.html#addBootModulePath(java.util.Deque)"
> class="member-name-link">addBootModulePath(Deque&lt;URL&gt;)</a> -
> Method in class org.apache.tomcat.util.compat.<a
> href="org/apache/tomcat/util/compat/Jre22Compat.html" title="class in
> org.apache.tomcat.util.compat">Jre22Compat</a></dt>
> │ │ +<dt><a
> href="org/apache/tomcat/util/compat/Jre19Compat.html#addBootModulePath(java.util.Deque)"
> class="member-name-link">addBootModulePath(Deque&lt;URL&gt;)</a> -
> Method in class org.apache.tomcat.util.compat.<a
> href="org/apache/tomcat/util/compat/Jre19Compat.html" title="class in
> org.apache.tomcat.util.compat">Jre19Compat</a></dt>
>
> The "left file" is the one I generated locally while the "right file" is
> the release artifact. So my build uses Jre22Compat in this javadoc file
> while yours references Jre19Compat.
>
> The file tomcat-9.0-doc/api/member-search-index.js has a similar
> exchange of Jre22Compat for Jre19Compat.

Neither option seems particularly wrong to me here.

> Note that I am using the same 17.0.12+7 compiler you are using plus Java
> 22.0.2 for the FFM bits. The details below are for my fully-automated
> tests which always use my latest JRE for everything.

Only the main Java is used for javadoc.

Rémy

> I am seeing some unit tests skipped that I am not expecting to be
> skipped. I wonder if my native components builds are working as expected.
>
> Details:
>
> * Environment
> *  Testing Apache Tomcat  9.0.93
> *  Java (build):    openjdk version "22.0.2" 2024-07-16 OpenJDK Runtime
> Environment Temurin-22.0.2+9 (build 22.0.2+9) OpenJDK 64-Bit Server VM
> Temurin-22.0.2+9 (build 22.0.2+9, mixed mode)
> *  Java (test):     22 ( openjdk version "22.0.2" 2024-07-16
> *  OS:              Darwin 23.5.0 x86_64
> *  cc:              Apple clang version 12.0.5 (clang-1205.0.22.9)
> *  make:            GNU Make 3.81
> *  OpenSSL:         OpenSSL 3.3.1 4 Jun 2024 (Library: OpenSSL 3.3.1 4
> Jun 2024)
> *  APR:             1.7.4
> *
> * Valid SHA-512 signature for apache-tomcat-9.0.93.zip
> * Valid GPG signature for apache-tomcat-9.0.93.zip
> * Valid SHA-512 signature for apache-tomcat-9.0.93.tar.gz
> * Valid GPG signature for apache-tomcat-9.0.93.tar.gz
> * Valid SHA-512 signature for apache-tomcat-9.0.93.exe
> * Valid GPG signature for apache-tomcat-9.0.93.exe
> * Valid Windows Digital Signature for apache-tomcat-9.0.93.exe
> * Valid SHA512 signature for apache-tomcat-9.0.93-src.zip
> * Valid GPG signature for apache-tomcat-9.0.93-src.zip
> * Valid SHA512 signature for apache-tomcat-9.0.93-src.tar.gz
> * Valid GPG signature for apache-tomcat-9.0.93-src.tar.gz
> *
> * Binary Zip and tarball: Same
> * Source Zip and tarball: Same
> *
> * Building dependencies returned: 0
> * tcnative builds cleanly
> * Tomcat builds cleanly
> * Junit Tests: PASSED
>
> -chris
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to