Am 05.08.24 um 20:18 schrieb Coty Sutherland:
I'm testing and see an issue with o.a.c.http2.TestStreamProcessor getting
some unexpected result:

Testcase: testPrepareHeaders[0: loop [0], useAsyncIO[false]] took 0.061 sec
     FAILED
expected:<...-Header-[etag]-[W/"9[34]-1447269522000"]
3-H...> but was:<...-Header-[etag]-[W/"9[57]-1447269522000"]
3-H...>
junit.framework.AssertionFailedError:
expected:<...-Header-[etag]-[W/"9[34]-1447269522000"]
3-H...> but was:<...-Header-[etag]-[W/"9[57]-1447269522000"]
3-H...>
     at
org.apache.coyote.http2.TestStreamProcessor.testPrepareHeaders(TestStreamProcessor.java:167)
     at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
     at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
     at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

The test class contains:

// Different line-endings -> different files size -> different weak eTag
        if (JrePlatform.IS_WINDOWS) {
            expected.append("3-Header-[etag]-[W/\"957-1447269522000\"]\n");
        } else {
            expected.append("3-Header-[etag]-[W/\"934-1447269522000\"]\n");
        }

The number behind the "W" (weak" in the etag header ist the file size, the second (correct) number the timestamp. It seems you get the 957 size exoected for Windows line endings instead of the 934 for Unix line endings. You could check the file test/webapp/index.html for size/line endings. Maybe your git settings lead to a DOS checkout instead of a unix one?

same output for:

Testcase: testPrepareHeaders[1: loop [0], useAsyncIO[true]] took 0.036 sec

This happens for all three branches. I ran the unit tests for using Fedora
40 with OpenJDK 17 (java-17-openjdk-17.0.11.0.9-1.fc39.x86_64) and 22
(java-22-openjdk-22.0.2.0.9-1.rolling.fc39.x86_64).

I'm also getting a failure in o.a.jasper.runtime.TestJspRuntimeLibrary.

What kind of failure?

Best regards,

Rainer

Any thoughts or know what might be up off the top of anyone's head? Given
that this seems fine for everyone else, I'm comfortable still giving a +1
and chalking it up to something odd in my environment.

On Fri, Aug 2, 2024 at 10:15 AM Mark Thomas <ma...@apache.org> wrote:

The proposed Apache Tomcat 11.0.0-M24 release is now available for
voting.

Apache Tomcat 11.0.0-M24 is a milestone release of the 11.0.x branch and
has been made to provide users with early access to the new features in
Apache Tomcat 11.0.x so that they may provide feedback. The notable
changes compared to 11.0.0-M22 include:

- Align HTTP/2 with HTTP/1.1 and recycle the container internal request
    and response processing objects by default. This behaviour can be
    controlled via the new discardRequestsAndResponses attribute on the
    HTTP/2 upgrade protocol.

- Add FFM compatibility methods for LibreSSL and BoringSSL support.

- Add support for RFC 8297 (Early Hints). Applications can use this
    feature by casting the HttpServletResponse to
    org.apache.catalina.connector.Reponse and then calling the method
    void sendEarlyHints()

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
without changes. Java EE applications designed for Tomcat 9 and earlier
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
will automatically convert them to Jakarta EE and copy them to the
webapps directory. Applications using deprecated APIs may require
further changes.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M24/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1507

The tag is:
https://github.com/apache/tomcat/tree/11.0.0-M24
5301df36454fcf22081108e25199f29904cadc79

The proposed 11.0.0-M24 release is:
[ ] -1 Broken - do not release
[ ] +1 Beta   - go ahead and release as 11.0.0-M24


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to