(tomcat) 01/03: Revert unnecessary changes for HTTP/2 request/response recycling

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit c89fe447dab9198498afa181e497092c2e6f9202
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Aug 2 10:36:54 2024 +0100

    Revert unnecessary changes for HTTP/2 request/response recycling
---
 java/org/apache/catalina/connector/CoyoteAdapter.java | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/java/org/apache/catalina/connector/CoyoteAdapter.java 
b/java/org/apache/catalina/connector/CoyoteAdapter.java
index aa5818aea0..5149e7e0db 100644
--- a/java/org/apache/catalina/connector/CoyoteAdapter.java
+++ b/java/org/apache/catalina/connector/CoyoteAdapter.java
@@ -308,18 +308,19 @@ public class CoyoteAdapter implements Adapter {
         if (request == null) {
             // Create objects
             request = connector.createRequest(req);
-            req.setNote(ADAPTER_NOTES, request);
-            
req.getParameters().setQueryStringCharset(connector.getURICharset());
-        }
-
-        if (response == null) {
             response = connector.createResponse(res);
+
+            // Link objects
+            request.setResponse(response);
+            response.setRequest(request);
+
+            // Set as notes
+            req.setNote(ADAPTER_NOTES, request);
             res.setNote(ADAPTER_NOTES, response);
-        }
 
-        // Link objects
-        request.setResponse(response);
-        response.setRequest(request);
+            // Set query string encoding
+            
req.getParameters().setQueryStringCharset(connector.getURICharset());
+        }
 
         if (connector.getXpoweredBy()) {
             response.addHeader("X-Powered-By", POWERED_BY);


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org