On 16/07/2024 10:40, r...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new a4d3724c25 Fix regression calling add-osgi
a4d3724c25 is described below
commit a4d3724c25a79ea7f0ebb4ccfb055d576da54789
Author: remm <r...@apache.org>
AuthorDate: Tue Jul 16 11:40:19 2024 +0200
Fix regression calling add-osgi
(and setup-bnd - the module-info.class was also missing)
Unless means not set at all, evaluating to false is not the same.
We could use:
unless="${skip.build.java.version}"
which does check for skip.build.java.version being set to true.
Changing add-osgi and setup-bnd to use that form should give consistent
behaviour whether the property is set or not.
If there are no objections, I'll make that change.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
