ChristopherSchultz commented on PR #734: URL: https://github.com/apache/tomcat/pull/734#issuecomment-2168032699
The Javabean specification says that boolean properties must have accessors (for readable properties) and mutators (for writable ones) called `boolean getFoo()` and/or `boolean getFoo()` and `void setFoo(boolean b)`. There is no requirement for `isFoo` versus `getFoo`. Ar Mark says, it's entirely a matter of style. Some examples including references: https://stackoverflow.com/a/39307501/276232 In English "get use-virtual-threads" is more readable and natural to me than "is use-virtual-threads". The best method name would probably be "should use-virtual-threads", but that breaks all accessor naming conventions, and therefore we wouldn't choose it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
