rmannibucau commented on code in PR #711:
URL: https://github.com/apache/tomcat/pull/711#discussion_r1636187299
##########
java/org/apache/coyote/AbstractProtocol.java:
##########
@@ -769,7 +769,7 @@ private void logPortOffset() {
// ------------------------------------------- Connection handler base
class
- protected static class ConnectionHandler<S> implements
AbstractEndpoint.Handler<S> {
+ public static class ConnectionHandler<S> implements
AbstractEndpoint.Handler<S> {
Review Comment:
Had the idea to make getGlobal returning RequestInfo directly (`public
RequestGroupInfo getGlobal() { return global; }`) but didn't push it so you are
right, will revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
