DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42444>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42444

           Summary: Potential NullPointerException in
                    org.apache.catalina.valves.AccessLogValve
           Product: Tomcat 6
           Version: 6.0.11
          Platform: All
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


In the class AccessLogValve.RequestElement in the method addElement there is an
access of the form: request.getProtocol(), even though the variable request is
known to be 'null' which will cause a NullPointerException.

Patch below:
---

Index:
F:/Workspace/Apache2/tomcat6/java/org/apache/catalina/valves/AccessLogValve.java
===================================================================
---
F:/Workspace/Apache2/tomcat6/java/org/apache/catalina/valves/AccessLogValve.java
        (revision
538877)
+++
F:/Workspace/Apache2/tomcat6/java/org/apache/catalina/valves/AccessLogValve.java
        (working
copy)
@@ -1035,7 +1035,7 @@
                 buf.append(request.getProtocol());
             } else {
                 buf.append("- - ");
-                buf.append(request.getProtocol());
+                // buf.append(request.getProtocol());
             }
         }
     }

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to