Am 08.12.23 um 15:04 schrieb Rémy Maucherat:
On Fri, Dec 8, 2023 at 3:01 PM Rainer Jung <rainer.j...@kippdata.de> wrote:

Hi Remy,

I tried to build TC 11 with Java 22, but cuirrenttly it fails with
errors like:

      [javac]
.../java/org/apache/tomcat/util/openssl/openssl_h_Macros.java:469:
error: MemorySegment is a preview API and is disabled by default.
      [javac]     public static void OCSP_RESPONSE_free(MemorySegment a) {
      [javac]                                           ^
      [javac]   (use --enable-preview to enable preview APIs)

The following classes fail like that:

.../java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
.../java/org/apache/tomcat/util/net/openssl/panama/OpenSSLSessionContext.java
.../java/org/apache/tomcat/util/net/openssl/panama/OpenSSLSessionStats.java
.../java/org/apache/tomcat/util/openssl/openssl_h_Compatibility.java
.../java/org/apache/tomcat/util/openssl/openssl_h.java
.../java/org/apache/tomcat/util/openssl/openssl_h_Macros.java

I didn't see anything prepared for "--enable-preview" in our ant scripts.

What does java -version says ?

The FFM API is no longer a preview API in the up to date Java 22
builds, so the flag is counter productive.
Downloads are here: https://jdk.java.net/22/

Rémy

Thanks Remy. I am at EA 19, current is EA 26. I guess it was included around 24 or 25. Unfortunately it is not mentioned in the release notes. Will try next time with the current EA build of jdk 22.


Best regards,

Rainer

Am 24.10.23 um 11:16 schrieb r...@apache.org:
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
       new 1185ad1154 Add message when not using Java 22 for release
1185ad1154 is described below

commit 1185ad1154cdbb8003efd29eeb1ccf95c87bdc56
Author: remm <r...@apache.org>
AuthorDate: Tue Oct 24 11:15:44 2023 +0200

      Add message when not using Java 22 for release

      Filter out packages with FFM API from javadoc.
---
   build.xml | 6 ++++++
   1 file changed, 6 insertions(+)

diff --git a/build.xml b/build.xml
index 12c720846e..e3cca8f964 100644
--- a/build.xml
+++ b/build.xml
@@ -2366,6 +2366,8 @@
           <include name="org/**"/>
           <exclude name="org/apache/el/parser/**"/>
           <exclude name="org/apache/tomcat/util/json/**"/>
+        <exclude name="org/apache/tomcat/util/net/openssl/panama/**"/>
+        <exclude name="org/apache/tomcat/util/openssl/**"/>
         </packageset>
         <!--jdbc-pool src files for javadoc-->
         <packageset dir="${tomcat.dist}/src/modules/jdbc-pool/src/main/java"/>
@@ -2654,6 +2656,10 @@ skip.installer property in build.properties" />
           <not><javaversion atleast="${release.java.version}" /></not>
         </condition>
       </fail>-->
+    <condition property="no-ffm">
+      <not><javaversion atleast="${release.java.version}" /></not>
+    </condition>
+     <echo level="error" if:set="no-ffm">JAVA VERSION 22 OR NEWER IS REQUIRED FOR 
RELEASE</echo>
     </target>

     <target name="-pre-release-lone-target-check">

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to