This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 6107ed1d33b3b3a1cd5ee150239b685a3b514c08
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Nov 27 13:47:03 2023 +0000
Add comment on why >= rather than == is used
---
java/javax/el/CompositeELResolver.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/java/javax/el/CompositeELResolver.java
b/java/javax/el/CompositeELResolver.java
index dade342c72..ee14d6bcc3 100644
--- a/java/javax/el/CompositeELResolver.java
+++ b/java/javax/el/CompositeELResolver.java
@@ -46,6 +46,10 @@ public class CompositeELResolver extends ELResolver {
public void add(ELResolver elResolver) {
Objects.requireNonNull(elResolver);
+ /*
+ * resolversSize should never be larger than resolvers.length. If it
ever is, the code will fail when execution
+ * reaches System.arraycopy with an IndexOutOfBoundsException.
+ */
if (resolversSize >= resolvers.length) {
ELResolver[] nr = new ELResolver[resolversSize * 2];
System.arraycopy(resolvers, 0, nr, 0, resolversSize);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
