I am not sure.
For the escaping: I did not observe a problem with and without the
escaping part. But I liked the additional safety net.
Concerning the wrong flag name in Makefile: unfortunately of the two
makefiles apache-2.0/Makefile and apache-2.0/Makefile.apxs the first one
is the one used by default. That's the one with the broken flag name.
libtool - at least the version used here - seems to ignore the wrong
flag name. So the effect we wanted - symbol reduction - does not happen.
So concerning the Makefile changes 1.2.49 is not worse than 1.2.48, but
unfortunately also not really better.
I added a comment to the original PR 66005.
I am fine with doing a new release, but not sure if it is worth it.
66005 is a nasty bug but is seems it has not hit too many people.
What do others think?
Best regards,
Rainer
Am 10.11.23 um 11:46 schrieb Mark Thomas:
On 10/11/2023 10:38, [email protected] wrote:
This is an automated email from the ASF dual-hosted git repository.
rjung pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git
The following commit(s) were added to refs/heads/main by this push:
new ecd005d07 BZ 68117: Fix typo and escaping in libtool flag
introduced in 1.2.49.
ecd005d07 is described below
commit ecd005d0792441c4510dc4c2d9348979ab71ddcc
Author: Rainer Jung <[email protected]>
AuthorDate: Fri Nov 10 11:38:04 2023 +0100
BZ 68117: Fix typo and escaping in libtool flag introduced in
1.2.49.
Do we need a new release because of this?
Asking as I have no clue how much of a problem this is.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
