(tomcat) branch 8.5.x updated: Refactor to use new SSLHostConfig instance for each test

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new 382c749fda Refactor to use new SSLHostConfig instance for each test
382c749fda is described below

commit 382c749fdaebc4857ce61d73b7fbab9faf6392de
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Nov 9 11:52:27 2023 +0000

    Refactor to use new SSLHostConfig instance for each test
    
    Random crashes have been observed on some platforms. This is intended to
    create greater isolation between tests.
---
 test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java 
b/test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java
index 00c81a8062..0705a54bf8 100644
--- a/test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java
+++ b/test/org/apache/tomcat/util/net/TestSSLHostConfigCompat.java
@@ -77,8 +77,6 @@ public class TestSSLHostConfigCompat extends TomcatBaseTest {
     @Parameter(3)
     public StoreType storeType;
 
-    private SSLHostConfig sslHostConfig = new SSLHostConfig();
-
 
     @Test
     public void testHostEC() throws Exception {
@@ -247,6 +245,7 @@ public class TestSSLHostConfigCompat extends TomcatBaseTest 
{
 
 
     private void configureHostRSA() {
+        SSLHostConfig sslHostConfig = getSSLHostConfig();
         switch (storeType) {
         case KEYSTORE: {
             SSLHostConfigCertificate sslHostConfigCertificateRsa = new 
SSLHostConfigCertificate(sslHostConfig, Type.RSA);
@@ -266,6 +265,7 @@ public class TestSSLHostConfigCompat extends TomcatBaseTest 
{
 
 
     private void configureHostEC() {
+        SSLHostConfig sslHostConfig = getSSLHostConfig();
         switch (storeType) {
         case KEYSTORE: {
             SSLHostConfigCertificate sslHostConfigCertificateEc = new 
SSLHostConfigCertificate(sslHostConfig, Type.EC);
@@ -329,6 +329,7 @@ public class TestSSLHostConfigCompat extends TomcatBaseTest 
{
             // Skip this for APR. It is not supported.
             Assert.assertTrue(connector.setProperty("sslImplementationName", 
sslImplementationName));
         }
+        SSLHostConfig sslHostConfig = new SSLHostConfig();
         sslHostConfig.setProtocols("TLSv1.2");
         connector.addSslHostConfig(sslHostConfig);
 
@@ -342,6 +343,13 @@ public class TestSSLHostConfigCompat extends 
TomcatBaseTest {
     }
 
 
+    private SSLHostConfig getSSLHostConfig() {
+        Tomcat tomcat = getTomcatInstance();
+        Connector connector = tomcat.getConnector();
+        return connector.findSslHostConfigs()[0];
+    }
+
+
     private static String getPath(String relativePath) {
         File f = new File(relativePath);
         return f.getAbsolutePath();


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org