On 05/11/2023 10:10, Mark Thomas wrote:
On 03/11/2023 15:07, Michael Osipov wrote:
On 2023/11/03 11:57:56 Mark Thomas wrote:
On 03/11/2023 09:26, Michael Osipov wrote:
This change now completely missed to enfore Java 17 on < 11 and
opt-in to skip the required during tests I have introduced last month.
Tomcat 11.0.x has required Java 21 to build for around 6 months. The BND
requirement for Java 17 has no impact on the build. Did you mean to
reference one of the older branches?
Yes, as written < Tomcat 11. Tomcat 9 failed for me with a cryptic
"Java class version..." that is why I have introduced the ant target
to have a clear message.
Ah. You replied to the commit message for 11.0.x and the meaning of < 11
was not clear. I thought it was somehow related to a Java version.
It looks like < Tomcat 11 isn't correct anyway. I only see the option to
skip the build version check in 9.0.x and 8.5.x.
If we can skip the OSGi task (haven't tested this at all) if the
skip.build.java.version is set then that should work. We should also add
a fail the build with a useful error message if someone tries "ant
release" with this property set.
Hmm. You still have to build with Java 17 but it is possible to add a
few further hacks to build.xml so the tests will still run with Java 8.
As the number of hacks increases, I become less convinced that it is
worth maintaining the ability to test with Java 8. I know that is the
minimum version but is the only reason to test on Java 8 that we don't
trust javac to honor the release target correctly? At this point, I see
no reason not to trust javac.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
