Michael,

On 10/19/23 08:30, Michael Osipov wrote:
On 2023/10/19 11:24:35 r...@apache.org wrote:
  java/org/apache/catalina/manager/StatusTransformer.java | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/java/org/apache/catalina/manager/StatusTransformer.java 
b/java/org/apache/catalina/manager/StatusTransformer.java
index e4fbf52ca7..3aa7f3e922 100644
--- a/java/org/apache/catalina/manager/StatusTransformer.java
+++ b/java/org/apache/catalina/manager/StatusTransformer.java
@@ -53,7 +53,7 @@ public class StatusTransformer {
          } else if (mode == 1) {
              response.setContentType("text/xml;charset=" + Constants.CHARSET);
          } else if (mode == 2) {
-            response.setContentType("application/json");
+            response.setContentType("application/json;charset=" + 
Constants.CHARSET);

This is not much better. There is no charset parameter for JSON: 
https://www.iana.org/assignments/media-types/application/json

While you are technically right (charset is only a valid parameter for text/* MIME types), this does not hurt and in fact fixes a bunch of stupid clients.

We could use text/json;charset=utf8 if we wanted to, and we'd be in good company[1]... at least back in 2015 :)

-chris

[1] https://en.wikipedia.org/wiki/JSON#cite_ref-faraday-stack-pull-2_31-0

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to