[tomcat] branch 8.5.x updated: Remove some instances of printStackTrace

[remm]

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new 8ac4986a35 Remove some instances of printStackTrace
8ac4986a35 is described below

commit 8ac4986a356fbe6c38a4e1c487540cbb405a9baf
Author: remm <r...@apache.org>
AuthorDate: Wed Oct 4 16:00:17 2023 +0200

    Remove some instances of printStackTrace
---
 java/org/apache/catalina/ha/session/DeltaRequest.java            | 3 ++-
 java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java | 4 +++-
 java/org/apache/el/lang/FunctionMapperImpl.java                  | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/java/org/apache/catalina/ha/session/DeltaRequest.java 
b/java/org/apache/catalina/ha/session/DeltaRequest.java
index 6f21d7f8b2..bbf48bac12 100644
--- a/java/org/apache/catalina/ha/session/DeltaRequest.java
+++ b/java/org/apache/catalina/ha/session/DeltaRequest.java
@@ -266,7 +266,8 @@ public class DeltaRequest implements Externalizable {
     public void setSessionId(String sessionId) {
         this.sessionId = sessionId;
         if (sessionId == null) {
-            new 
Exception(sm.getString("deltaRequest.ssid.null")).fillInStackTrace().printStackTrace();
+            Exception e = new 
Exception(sm.getString("deltaRequest.ssid.null"));
+            log.error(sm.getString("deltaRequest.ssid.null"), 
e.fillInStackTrace());
         }
     }
 
diff --git a/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java 
b/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
index f8a7151d64..3b91ac0290 100644
--- a/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
+++ b/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
@@ -1142,7 +1142,9 @@ public abstract class AbstractReplicatedMap<K,V>
             }
             System.out.println("EndMap]\n\n");
         }catch ( Exception ignore) {
-            ignore.printStackTrace();
+            if (log.isTraceEnabled()) {
+                log.trace("Error printing map", ignore);
+            }
         }
     }
 
diff --git a/java/org/apache/el/lang/FunctionMapperImpl.java 
b/java/org/apache/el/lang/FunctionMapperImpl.java
index 591e2a7cbd..56ff1f66d1 100644
--- a/java/org/apache/el/lang/FunctionMapperImpl.java
+++ b/java/org/apache/el/lang/FunctionMapperImpl.java
@@ -158,7 +158,7 @@ public class FunctionMapperImpl extends FunctionMapper 
implements
                     Class<?>[] p = ReflectionUtil.toTypeArray(this.types);
                     this.m = t.getMethod(this.name, p);
                 } catch (Exception e) {
-                    e.printStackTrace();
+                    // Ignore: this results in ELException after further 
resolution
                 }
             }
             return this.m;


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org