This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 075942b0eb Remove some instances of printStackTrace
075942b0eb is described below
commit 075942b0ebd53aa111ea814afb1c5d57df85daa0
Author: remm <[email protected]>
AuthorDate: Wed Oct 4 16:00:17 2023 +0200
Remove some instances of printStackTrace
---
java/org/apache/catalina/ha/session/DeltaRequest.java | 3 ++-
java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java | 4 +++-
java/org/apache/el/lang/FunctionMapperImpl.java | 2 +-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/java/org/apache/catalina/ha/session/DeltaRequest.java
b/java/org/apache/catalina/ha/session/DeltaRequest.java
index 6f21d7f8b2..bbf48bac12 100644
--- a/java/org/apache/catalina/ha/session/DeltaRequest.java
+++ b/java/org/apache/catalina/ha/session/DeltaRequest.java
@@ -266,7 +266,8 @@ public class DeltaRequest implements Externalizable {
public void setSessionId(String sessionId) {
this.sessionId = sessionId;
if (sessionId == null) {
- new
Exception(sm.getString("deltaRequest.ssid.null")).fillInStackTrace().printStackTrace();
+ Exception e = new
Exception(sm.getString("deltaRequest.ssid.null"));
+ log.error(sm.getString("deltaRequest.ssid.null"),
e.fillInStackTrace());
}
}
diff --git a/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
b/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
index 47daef11ed..c63bfb0cad 100644
--- a/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
+++ b/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
@@ -1142,7 +1142,9 @@ public abstract class AbstractReplicatedMap<K,V>
}
System.out.println("EndMap]\n\n");
}catch ( Exception ignore) {
- ignore.printStackTrace();
+ if (log.isTraceEnabled()) {
+ log.trace("Error printing map", ignore);
+ }
}
}
diff --git a/java/org/apache/el/lang/FunctionMapperImpl.java
b/java/org/apache/el/lang/FunctionMapperImpl.java
index a9ef2bc743..07a02d8b08 100644
--- a/java/org/apache/el/lang/FunctionMapperImpl.java
+++ b/java/org/apache/el/lang/FunctionMapperImpl.java
@@ -158,7 +158,7 @@ public class FunctionMapperImpl extends FunctionMapper
implements
Class<?>[] p = ReflectionUtil.toTypeArray(this.types);
this.m = t.getMethod(this.name, p);
} catch (Exception e) {
- e.printStackTrace();
+ // Ignore: this results in ELException after further
resolution
}
}
return this.m;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
