This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push: new c6e0dd7131 Remove use of printStackTrace c6e0dd7131 is described below commit c6e0dd7131a084a37fd65b301ce12a4bb5eed8c3 Author: remm <r...@apache.org> AuthorDate: Mon Oct 2 15:17:13 2023 +0200 Remove use of printStackTrace --- java/org/apache/tomcat/util/http/LocalStrings.properties | 1 + java/org/apache/tomcat/util/http/Parameters.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/java/org/apache/tomcat/util/http/LocalStrings.properties b/java/org/apache/tomcat/util/http/LocalStrings.properties index 43307a8893..e0f0d494f6 100644 --- a/java/org/apache/tomcat/util/http/LocalStrings.properties +++ b/java/org/apache/tomcat/util/http/LocalStrings.properties @@ -26,6 +26,7 @@ parameters.bytes=Start processing with input [{0}] parameters.copyFail=Failed to create copy of original parameter values for debug logging purposes parameters.decodeFail.debug=Character decoding failed. Parameter [{0}] with value [{1}] has been ignored. parameters.decodeFail.info=Character decoding failed. Parameter [{0}] with value [{1}] has been ignored. Note that the name and value quoted here may be corrupted due to the failed decoding. Use debug level logging to see the original, non-corrupted values. +parameters.duplicateFail=Failed to create copy of query parameters parameters.emptyChunk=Empty parameter chunk ignored parameters.fallToDebug=\n\ \ Note: further occurrences of Parameter errors will be logged at DEBUG level. diff --git a/java/org/apache/tomcat/util/http/Parameters.java b/java/org/apache/tomcat/util/http/Parameters.java index 29a6bc0f91..a0fb09bbe3 100644 --- a/java/org/apache/tomcat/util/http/Parameters.java +++ b/java/org/apache/tomcat/util/http/Parameters.java @@ -189,7 +189,7 @@ public final class Parameters { decodedQuery.duplicate(queryMB); } catch (IOException e) { // Can't happen, as decodedQuery can't overflow - e.printStackTrace(); + log.error(sm.getString("parameters.copyFail"), e); } processParameters(decodedQuery, queryStringCharset); } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org