On 28/09/2023 20:14, Christopher Schultz wrote:
1. The resulting binary is libtcnative-2.0.dylib and not
libtcnative-2.0.6.dylib. Is that expected?
Yes. That is consistent with previous versions I have built locally.
2. Build warnings are mostly deprecation warnings. Given that most of
the deprecations occurred in OpenSSL 3.0 and libtcnative 2.x requires
OpenSSL 3.0 or later, should we migrate this source to use the
replacement functions instead? Or are we trying to keep the code as
close to 1.x as possible?
For 2.0.x we can/should migrate to the new functions.
For 1.2.x we need to retain compatibility with 1.0.2. If we move to
1.3.x we only need to retain compatibility with 1.1.1..
Either way, if we want to fix the deprecation in 1.2.x when building
with 3.0.x onwards, we'll need some "#if OPENSSL_VERSION_NUMBER ..."
directives
3. Some warnings are "unused variable" and "unused function". If those
are accurate -- all are "static" and thus file-scoped aka private --
we should clean them up.
Interesting. I see those warnings on MacOS but not on Linux. Looks like
configure sets things up slightly differently for Linux and MacOS.
I have removed that unused code in 2.0.6. Thanks for spotting it.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
