[tomcat] branch 9.0.x updated: Avoid unlikely NPE

[remm]

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new 4f117a021b Avoid unlikely NPE
4f117a021b is described below

commit 4f117a021bf5d7e759e5a30ff6eb7e1ee176ce7d
Author: remm <r...@apache.org>
AuthorDate: Wed Sep 20 10:21:14 2023 +0200

    Avoid unlikely NPE
    
    Really not supposed to happen after a directory listing, but it's still
    best to do clean logging.
    Found by coverity.
---
 java/org/apache/tomcat/util/scan/StandardJarScanner.java | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/tomcat/util/scan/StandardJarScanner.java 
b/java/org/apache/tomcat/util/scan/StandardJarScanner.java
index 54bab19796..1ca5bd1afd 100644
--- a/java/org/apache/tomcat/util/scan/StandardJarScanner.java
+++ b/java/org/apache/tomcat/util/scan/StandardJarScanner.java
@@ -191,8 +191,12 @@ public class StandardJarScanner implements JarScanner {
                     URL url = null;
                     try {
                         url = context.getResource(path);
-                        processedURLs.add(url);
-                        process(scanType, callback, url, path, true, null);
+                        if (url != null) {
+                            processedURLs.add(url);
+                            process(scanType, callback, url, path, true, null);
+                        } else {
+                            log.warn(sm.getString("jarScan.webinflibFail", 
path));
+                        }
                     } catch (IOException e) {
                         log.warn(sm.getString("jarScan.webinflibFail", url), 
e);
                     }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org