This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit bf7bd10432f02e4a2428ef4d33dfc3a2d3081948 Author: Mark Thomas <ma...@apache.org> AuthorDate: Sat Sep 16 09:56:50 2023 +0100 Update false positives for FileUpload --- res/spotbugs/filter-false-positives.xml | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml index 9794f86322..70baa748a0 100644 --- a/res/spotbugs/filter-false-positives.xml +++ b/res/spotbugs/filter-false-positives.xml @@ -1547,33 +1547,12 @@ <Method name="processCookieHeader"/> <Bug code="SF" /> </Match> - <Match> - <!-- the platform default encoding is a fallback --> - <Class name="org.apache.tomcat.util.http.fileupload.MultipartStream"/> - <Method name="readHeaders"/> - <Bug code="Dm" /> - </Match> <Match> <!-- Deletion failure should never happen --> <Class name="org.apache.tomcat.util.http.fileupload.disk.DiskFileItem"/> - <Or> - <Method name="delete"/> - <Method name="finalize"/> - </Or> + <Method name="finalize"/> <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> </Match> - <Match> - <!-- the platform default encoding is a fallback --> - <Class name="org.apache.tomcat.util.http.fileupload.disk.DiskFileItem"/> - <Method name="getString"/> - <Bug code="Dm" /> - </Match> - <Match> - <!-- the platform default encoding is deliberate --> - <Class name="org.apache.tomcat.util.http.fileupload.util.Streams"/> - <Method name="asString"/> - <Bug code="Dm" /> - </Match> <Match> <!-- Fall-through expected --> <Class name="org.apache.tomcat.util.http.parser.Cookie" /> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org