On 15/09/2023 18:55, Coty Sutherland wrote:
On Fri, Sep 15, 2023 at 8:43 AM Rémy Maucherat <r...@apache.org> wrote:
On Fri, Sep 15, 2023 at 2:38 PM Mark Thomas <ma...@apache.org> wrote:
<snip/>
Since we have little choice for Tomcat 8.5.x and 9.0.x, I will be
aligning these branches with FileUpload 1.x first.
I'm not a huge fan of pulling a large chunk of Commons IO or on making
sufficient changes to our fork so we don't have to. I am therefore
currently planning on aligning 10.1.x and 11.0.x with FileUpload 1.x as
well.
I do intend to see if there are changes from FileUpload 2.x that are
worth cherry-picking into Tomcat (and FileUpload 1.x) if minimum Java
versions permit.
All that said, the Jakarta EE Migration tool already includes a package
renamed copy of Commons IO (as well as Lang and Compress) so there might
be something we co do there - maybe a new Commons forks JAR?
Thoughts?
+1 on staying with fileupload 1.x for all branches then, for the time
being. 11 could move to 2.x eventually it seems.
+1
I tend to agree with sticking with 1.x. However, it appears I was
underestimating somewhat when I said Tomcat had a "few" commits that 1.x
didn't have.
I still think this is the way to go but there are ~3 years worth of
commits to work through. Also, Tomcat has picked up some of the 2.x
refactoring that will need to be reverted. It looks like this is going
to take a while.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
