This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push: new ca095d52c9 Fix javadoc and documentation. ca095d52c9 is described below commit ca095d52c98c2e25005990a9ef02240a823f0334 Author: lihan <li...@apache.org> AuthorDate: Fri Sep 1 10:43:45 2023 +0800 Fix javadoc and documentation. Update the default value of 'socket.processorCache' and 'socket.eventCache' in the documentation and javadoc. And remove 'socket.keyCache' from the AJP documentation. --- java/org/apache/tomcat/util/net/SocketProperties.java | 8 ++++---- webapps/docs/config/ajp.xml | 13 +++---------- webapps/docs/config/http.xml | 2 +- 3 files changed, 8 insertions(+), 15 deletions(-) diff --git a/java/org/apache/tomcat/util/net/SocketProperties.java b/java/org/apache/tomcat/util/net/SocketProperties.java index 1cdb2c6302..b91d54f0e2 100644 --- a/java/org/apache/tomcat/util/net/SocketProperties.java +++ b/java/org/apache/tomcat/util/net/SocketProperties.java @@ -36,7 +36,7 @@ public class SocketProperties { /** * Enable/disable socket processor cache, this bounded cache stores * SocketProcessor objects to reduce GC - * Default is 500 + * Default is 0 * -1 is unlimited * 0 is disabled */ @@ -45,7 +45,7 @@ public class SocketProperties { /** * Enable/disable poller event cache, this bounded cache stores * PollerEvent objects to reduce GC for the poller - * Default is 500 + * Default is 0 * -1 is unlimited * 0 is disabled * >0 the max number of objects to keep in cache. @@ -78,13 +78,13 @@ public class SocketProperties { /** * The application read buffer size in bytes. - * Default value is rxBufSize + * Default value is 8192 */ protected int appReadBufSize = 8192; /** * The application write buffer size in bytes - * Default value is txBufSize + * Default value is 8192 */ protected int appWriteBufSize = 8192; diff --git a/webapps/docs/config/ajp.xml b/webapps/docs/config/ajp.xml index 6eda243d89..bc85a734b3 100644 --- a/webapps/docs/config/ajp.xml +++ b/webapps/docs/config/ajp.xml @@ -720,21 +720,14 @@ <attribute name="socket.processorCache" required="false"> <p>(int)Tomcat will cache SocketProcessor objects to reduce garbage collection. The integer value specifies how many objects to keep in the - cache at most. The default is <code>500</code>. Other values are - <code>-1</code> for unlimited cache and <code>0</code> for no cache.</p> - </attribute> - - <attribute name="socket.keyCache" required="false"> - <p>(int)Tomcat will cache KeyAttachment objects to reduce garbage - collection. The integer value specifies how many objects to keep in the - cache at most. The default is <code>500</code>. Other values are + cache at most. The default is <code>0</code>. Other values are <code>-1</code> for unlimited cache and <code>0</code> for no cache.</p> </attribute> <attribute name="socket.eventCache" required="false"> <p>(int)Tomcat will cache PollerEvent objects to reduce garbage collection. The integer value specifies how many objects to keep in the - cache at most. The default is <code>500</code>. Other values are + cache at most. The default is <code>0</code>. Other values are <code>-1</code> for unlimited cache and <code>0</code> for no cache.</p> </attribute> @@ -794,7 +787,7 @@ <attribute name="socket.processorCache" required="false"> <p>(int)Tomcat will cache SocketProcessor objects to reduce garbage collection. The integer value specifies how many objects to keep in the - cache at most. The default is <code>500</code>. Other values are + cache at most. The default is <code>0</code>. Other values are <code>-1</code> for unlimited cache and <code>0</code> for no cache.</p> </attribute> diff --git a/webapps/docs/config/http.xml b/webapps/docs/config/http.xml index 5bc3c4a6e4..9cbab65964 100644 --- a/webapps/docs/config/http.xml +++ b/webapps/docs/config/http.xml @@ -1008,7 +1008,7 @@ <attribute name="socket.processorCache" required="false"> <p>(int)Tomcat will cache SocketProcessor objects to reduce garbage collection. The integer value specifies how many objects to keep in the - cache at most. The default is <code>500</code>. Other values are + cache at most. The default is <code>0</code>. Other values are <code>-1</code> for unlimited cache and <code>0</code> for no cache.</p> </attribute> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org