This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 4f39b02eed Consistent synchronization - reported by Coverity
4f39b02eed is described below
commit 4f39b02eed0897fcbf2491e0e93dacd022506da1
Author: Mark Thomas <[email protected]>
AuthorDate: Thu Aug 10 15:36:28 2023 +0100
Consistent synchronization - reported by Coverity
---
java/org/apache/catalina/core/StandardService.java | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/catalina/core/StandardService.java
b/java/org/apache/catalina/core/StandardService.java
index c615b75204..c6216f6174 100644
--- a/java/org/apache/catalina/core/StandardService.java
+++ b/java/org/apache/catalina/core/StandardService.java
@@ -242,11 +242,13 @@ public class StandardService extends LifecycleMBeanBase
implements Service {
public ObjectName[] getConnectorNames() {
- ObjectName results[] = new ObjectName[connectors.length];
- for (int i = 0; i < results.length; i++) {
- results[i] = connectors[i].getObjectName();
+ synchronized (connectorsLock) {
+ ObjectName results[] = new ObjectName[connectors.length];
+ for (int i = 0; i < results.length; i++) {
+ results[i] = connectors[i].getObjectName();
+ }
+ return results;
}
- return results;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
