This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit a33a493ef76a38d542e5c1060cbff8c534fe4e79
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Aug 4 15:01:16 2023 +0100

    Remove unused return value
---
 java/org/apache/catalina/connector/Response.java | 11 +++--------
 java/org/apache/coyote/Response.java             | 11 +++--------
 2 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/java/org/apache/catalina/connector/Response.java 
b/java/org/apache/catalina/connector/Response.java
index 6cf4893d0e..124a5d67bc 100644
--- a/java/org/apache/catalina/connector/Response.java
+++ b/java/org/apache/catalina/connector/Response.java
@@ -369,15 +369,10 @@ public class Response implements HttpServletResponse {
 
 
     /**
-     * Set the error flag.
-     *
-     * @return <code>false</code> if the error flag was already set
-     *
-     * @deprecated This method will be changed to return void in Tomcat 11 
onwards
+     * Set the error flag if not already set.
      */
-    @Deprecated
-    public boolean setError() {
-        return getCoyoteResponse().setError();
+    public void setError() {
+        getCoyoteResponse().setError();
     }
 
 
diff --git a/java/org/apache/coyote/Response.java 
b/java/org/apache/coyote/Response.java
index 64920c2993..6e4991ac30 100644
--- a/java/org/apache/coyote/Response.java
+++ b/java/org/apache/coyote/Response.java
@@ -304,15 +304,10 @@ public final class Response {
 
 
     /**
-     * Set the error flag.
-     *
-     * @return <code>false</code> if the error flag was already set
-     *
-     * @deprecated This method will be changed to return void in Tomcat 11 
onwards
+     * Set the error flag if not already set.
      */
-    @Deprecated
-    public boolean setError() {
-        return errorState.compareAndSet(0, 1);
+    public void setError() {
+        errorState.compareAndSet(0, 1);
     }
 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to