[tomcat] branch 10.1.x updated: Fix BZ 66822. Use same name format for Connector and ProtocolHandler

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
     new 895d972aab Fix BZ 66822. Use same name format for Connector and 
ProtocolHandler
895d972aab is described below

commit 895d972aab886aa58ff90535e0f07cbd9a56bb0f
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Aug 3 14:40:03 2023 +0100

    Fix BZ 66822. Use same name format for Connector and ProtocolHandler
    
    https://bz.apache.org/bugzilla/show_bug.cgi?id=66822
---
 java/org/apache/catalina/connector/Connector.java | 27 ++++++++++++++---------
 webapps/docs/changelog.xml                        |  4 ++++
 2 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/java/org/apache/catalina/connector/Connector.java 
b/java/org/apache/catalina/connector/Connector.java
index 18e865e157..31acb19fa3 100644
--- a/java/org/apache/catalina/connector/Connector.java
+++ b/java/org/apache/catalina/connector/Connector.java
@@ -1099,19 +1099,24 @@ public class Connector extends LifecycleMBeanBase {
     public String toString() {
         // Not worth caching this right now
         StringBuilder sb = new StringBuilder("Connector[");
-        sb.append(getProtocol());
-        sb.append('-');
-        String id = (protocolHandler != null) ? protocolHandler.getId() : null;
-        if (id != null) {
-            sb.append(id);
-        } else {
-            int port = getPortWithOffset();
-            if (port > 0) {
-                sb.append(port);
+        String name = (String) getProperty("name");
+        if (name == null) {
+            sb.append(getProtocol());
+            sb.append('-');
+            String id = (protocolHandler != null) ? protocolHandler.getId() : 
null;
+            if (id != null) {
+                sb.append(id);
             } else {
-                sb.append("auto-");
-                sb.append(getProperty("nameIndex"));
+                int port = getPortWithOffset();
+                if (port > 0) {
+                    sb.append(port);
+                } else {
+                    sb.append("auto-");
+                    sb.append(getProperty("nameIndex"));
+                }
             }
+        } else {
+            sb.append(name);
         }
         sb.append(']');
         return sb.toString();
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index bd5ba533b3..c27bf82c50 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -116,6 +116,10 @@
         Catch <code>NamingException</code> in 
<code>JNDIRealm#getPrincipal</code>.
         It is used in Java up to 17 to signal closed connections. (fschumacher)
       </fix>
+      <fix>
+        <bug>66822</bug>: Use the same naming format in log messages for
+        Connector instances as the associated ProtocolHandler instance. (markt)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Coyote">


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org