ChristopherSchultz commented on PR #639: URL: https://github.com/apache/tomcat/pull/639#issuecomment-1638643485
This looks good to me, but I'd appreciate someone with more in-depth knowledge of the protocol handlers to weigh-in. The only thing that caught my eye was that the signature of `AbstractNetworkChannelEndpoint.createChannel` has changed by widening the return value from `NetworkChannel` to `Channel`. This change is not backward compatible and we might want to introduce a new method instead of changing the signature of the current one. This pull request is against `main`, so this change is okay, but back-porting to other stable releases I think is not okay for this reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
