This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 957f37ed36 Remove unnecessary code
957f37ed36 is described below
commit 957f37ed36c0b58f9e99f7db806dc3969f9f46ca
Author: Mark Thomas <[email protected]>
AuthorDate: Wed Jul 5 17:34:03 2023 +0100
Remove unnecessary code
Dead code identified by Coverity Scan
---
java/org/apache/coyote/http2/StreamProcessor.java | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/java/org/apache/coyote/http2/StreamProcessor.java
b/java/org/apache/coyote/http2/StreamProcessor.java
index f9dfefc8f0..80c04ed5cc 100644
--- a/java/org/apache/coyote/http2/StreamProcessor.java
+++ b/java/org/apache/coyote/http2/StreamProcessor.java
@@ -466,17 +466,12 @@ class StreamProcessor extends AbstractProcessor {
}
// HTTP header names must be tokens.
+ // Stream#emitHeader() checks that all the pseudo headers appear first.
MimeHeaders headers = request.getMimeHeaders();
- boolean previousHeaderWasPseudoHeader = true;
Enumeration<String> names = headers.names();
while (names.hasMoreElements()) {
String name = names.nextElement();
- if (H2_PSEUDO_HEADERS_REQUEST.contains(name)) {
- if (!previousHeaderWasPseudoHeader) {
- return false;
- }
- } else if (!HttpParser.isToken(name)) {
- previousHeaderWasPseudoHeader = false;
+ if (!H2_PSEUDO_HEADERS_REQUEST.contains(name) &&
!HttpParser.isToken(name)) {
return false;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
