https://bz.apache.org/bugzilla/show_bug.cgi?id=66670

--- Comment #5 from Christopher Schultz <ch...@christopherschultz.net> ---
(In reply to Michael Osipov from comment #2)
> * From code, this will not work, XML only

True, but not really relevant. If you want to re-use passwords (or files), you
can do that in your code pretty easily.

> * Most people don't even know system identifiers or DTDs at all

Also true, but this is standard XML and not some weird hand-wavy thing that
Tomcat invented like "property sources".

> * What will happen if the file contains a line separator? Will it be
> stripped automatically?

I haven't done extensive testing, but I believe exotic whitespace will be
preserved. So if you have a trailing newline in your file, then your password
will also have a trailing newline. So be careful.

But you'd have to do that, anyway. If Tomcat were to implement a "use this file
here" attribute resolver, then we would not want to be doing things like
trimming whitespace or anything like that, either.

(In reply to Remy Maucherat from comment #3)
> .../ServiceBindingPropertySource

This was going to be my next suggestion. I only recently discovered this
capability existed and I fully intend to start playing-around with it because
our current build process requires us to build locally in each environment to
get e.g. database credentials into the right place in context.xml.

But... I think the ServiceBindingPropertySource only works with applications,
not with server.xml, right Rémy?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to